Allow BasicHttpPoster to reuse HTTP connections - #379
Merged
Conversation
BasicHttpPoster previously constructed and closed a pooled HTTP client for every request, preventing connection reuse across AS4 messages. Add an optional caller-owned manager while preserving the existing per-request lifecycle by default.\n\nCover the behavior with a loopback test that verifies two sends use one TCP connection and that the poster does not close the shared manager.
Contributor
Author
|
Consumer impact: phase4 currently creates and closes a pooled HTTP client for every AS4 send, so connections cannot be reused between messages. The optional shared manager preserves the default lifecycle while allowing long-running access points to reuse TCP/TLS connections. The loopback test verifies two sends use the same connection and that the caller-owned manager remains open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.